Fix goto-def on partial methods in LSP #68559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jun 12, 2023
|
|
||
| namespace Microsoft.CodeAnalysis.GoToDefinition | ||
| { | ||
| internal static class GoToDefinitionHelpers | ||
| { | ||
| public static async Task<ImmutableArray<DefinitionItem>> GetDefinitionsAsync( |
There was a problem hiding this comment.
moved to common location. not tied to 'EditorFeatures' (e.g. VS) impl of goto-def.
CyrusNajmabadi
commented
Jun 12, 2023
| symbol = await SymbolFinder.FindSourceDefinitionAsync(symbol, project.Solution, cancellationToken).ConfigureAwait(false) ?? symbol; | ||
| var solution = project.Solution; | ||
| symbol = await SymbolFinder.FindSourceDefinitionAsync(symbol, solution, cancellationToken).ConfigureAwait(false) ?? symbol; | ||
| symbol = await GoToDefinitionFeatureHelpers.TryGetPreferredSymbolAsync(solution, symbol, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
this continues the long pain of having something like 3 different goto-def impls in roslyn, which do/don't use the same set of underlying helpers to get consistent results. This includes IGoToDefinitionService, IAsyncGoToDefinitionService, and IFindDefinitionService. Ideally we can get to a place where this all gets burned down. But it's woven so deeply into different systems that that's going to be very hard for a while.
CyrusNajmabadi
commented
Jun 12, 2023
| { | ||
| internal static class GoToDefinitionFeatureHelpers | ||
| { | ||
| public static async Task<ISymbol?> TryGetPreferredSymbolAsync( |
CyrusNajmabadi
commented
Jun 12, 2023
| ISymbol? symbol, | ||
| Solution solution, | ||
| bool thirdPartyNavigationAllowed, | ||
| CancellationToken cancellationToken) |
dibarbet
approved these changes
Jun 12, 2023
|
Nice, our first forcing function to validate the roslyn server insertion infra for VSCode! |
arkalyanms
approved these changes
Jun 12, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#5740