Only make members required when RequiredMemberAttribute is present #68577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
mavasani
approved these changes
Jun 13, 2023
Youssef1313
reviewed
Jun 13, 2023
src/Analyzers/CSharp/CodeFixes/MakeMemberRequired/CSharpMakeMemberRequiredCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Tests/MakeMemberRequired/MakeMemberRequiredTests.cs
Show resolved
Hide resolved
Comment on lines
+123
to
+124
| [Fact] | ||
| [WorkItem("https://github.com/dotnet/roslyn/issues/68478")] |
There was a problem hiding this comment.
Suggested change
| [Fact] | |
| [WorkItem("https://github.com/dotnet/roslyn/issues/68478")] | |
| [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/68478")] |
There was a problem hiding this comment.
➡️ Keeping this one as-is
| public async Task SimpleSetPropertyMissingRequiredAttribute() | ||
| { | ||
| var code = | ||
| """ |
There was a problem hiding this comment.
my preference would also be consistency. but it's not a deal breaker.
CyrusNajmabadi
approved these changes
Jun 13, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68478