Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hint diagnostics in vscode for better rendering in the editor #69403

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 4, 2023

Information diagnostics are rendered in blue squiggles whereas hint diagnostics are rendered as 3 dots. People found the blue squiggles to be too noisy - so in vscode we convert info diagnostics to hint

Before
image

After
image

@dibarbet dibarbet requested a review from a team as a code owner August 4, 2023 19:54
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 4, 2023
@dibarbet dibarbet enabled auto-merge August 4, 2023 20:24
@jasonmalinowski
Copy link
Member

@dibarbet If I recall, hint diagnostics in VS for Windows do three dots, right? So ignoring the diverging LSP behaviors for a moment, this makes the user experience the same?

@dibarbet
Copy link
Member Author

dibarbet commented Aug 4, 2023

@dibarbet If I recall, hint diagnostics in VS for Windows do three dots, right? So ignoring the diverging LSP behaviors for a moment, this makes the user experience the same?

Almost the same. In vscode hint diagnostics do not show up in problems. In VS (since we report them as information and info gets rendered as 3 dots) they do show up in the error list

@dibarbet dibarbet merged commit e42f43e into dotnet:main Aug 4, 2023
23 of 24 checks passed
@ghost ghost added this to the Next milestone Aug 4, 2023
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants