Shorten the namedpipe used to connect with C# extension #70492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
The error message mentions domain soxkets. Is there another socket type we should use that doesn't have this limitation? |
|
Good question Cyrus! NamedPipes are setting the domain socket, and don't give us any options to control that. |
|
Yeah pretty sure domain socket just means IPC socket (instead of some network socket). |
dibarbet
approved these changes
Oct 20, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path created by mac can be too long and causes an error. I've shorted the pipe name to be just the first segment of a guid. We are only creating one pipe, so there shouldn't be concern with collisions.
[stderr] Unhandled exception: System.ArgumentOutOfRangeException: The path '/var/folders/rh/p2xvyg710y15pmy1bf75ds340000gn/T/com.apple.shortcuts.mac-helper/f2622daa-af31-4dce-bb8e-787f1d869eba.sock' is of an invalid length for use with domain sockets on this platform. The length must be between 1 and 104 characters, inclusive. (Parameter 'path')Issue: dotnet/vscode-csharp#6485