Make GetDeclaredSymbol more strongly typed for LocalFunctionDeclarationSyntax #71034
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@333fred @jcouv @RikkiGibson trivial type safety PR. |
|
@RikkiGibson Yup. These should always be strongly typed. The only times they shouldn't be is if you can genuinely get different symbol types back. For example, an IPropertySymbol and an IMethodSymbol (which share no common base interface except ISymbol) :) |
| @@ -2960,7 +2960,7 @@ internal Conversion ClassifyConversionForCast(int position, ExpressionSyntax exp | |||
| /// <param name="declarationSyntax">The syntax node that declares a member.</param> | |||
| /// <param name="cancellationToken">The cancellation token.</param> | |||
| /// <returns>The symbol that was declared.</returns> | |||
| public abstract ISymbol GetDeclaredSymbol(LocalFunctionStatementSyntax declarationSyntax, CancellationToken cancellationToken = default(CancellationToken)); | |||
| public abstract IMethodSymbol GetDeclaredSymbol(LocalFunctionStatementSyntax declarationSyntax, CancellationToken cancellationToken = default(CancellationToken)); | |||
There was a problem hiding this comment.
Huh. I was going to suggest that we should update the public API for this as well, but we apparently don't have a GetDeclaredSymbol extension for local functions. That seems like a bug in itself, as it means that dotnet/roslyn-analyzers#6779 is going to warn when calling GetDeclaredSymbol on a local function syntax node.
There was a problem hiding this comment.
And now I see that you're driving this because of a request for just such an API in #71028 😆.
ghost
added this to the 
No description provided.