Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report better warnings and errors if build hosts exit abnormally #71909

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Report better warnings and errors if build hosts exit abnormally #71909

merged 4 commits into from
Feb 5, 2024

Commits on Feb 1, 2024

  1. Log the process log if the BuildHost exits with a non-zero code 

    This avoids having to flip to trace mode just to find the cause of the
failure.
    @jasonmalinowski
    jasonmalinowski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    860d45a View commit details
    Browse the repository at this point in the history

  2. Rewrite test to not use MSBuildProjectLoader 

    I'm not sure why this test is directly tesing MSBuildProjectLoder when
we instead could have used the API that literally every other test uses.
    @jasonmalinowski
    jasonmalinowski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5db5647 View commit details
    Browse the repository at this point in the history

  3. Report workspace messages for warnings/errors from the build hosts 

    This connects our various error reporting systems so failures of the
build hosts can get passed along back to the existing reporting
mechanism for MSBuildWorkspace failures.
    @jasonmalinowski
    jasonmalinowski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    19751d7 View commit details
    Browse the repository at this point in the history

  4. Add a direct test to test MSBuildProjectLoader

    @jasonmalinowski
    jasonmalinowski committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    de6f68a View commit details
    Browse the repository at this point in the history