Provide all possible keywords in xml doc comment langword tag
#72694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
DoctorKrolic
commented
Mar 23, 2024
|
|
||
| foreach (var keywordKind in SyntaxFacts.GetKeywordKinds()) | ||
| { | ||
| var keywordText = SyntaxFacts.GetText(keywordKind); |
There was a problem hiding this comment.
This is reusing the same logic as the actual product code, which isn't great for a test at all, but I cannot think of a better solution here. Another option is to manually list all keywords we need to check for, but this is an unmanageble nightmare. We sort of want keyword list to be tight to SyntaxFacts.GetKeywordKinds, so as new keywords are added to the language we immediately test that they are in the list. Same thing on VB side
CyrusNajmabadi
approved these changes
Mar 23, 2024
|
test failure seems legit. |
|
@CyrusNajmabadi PTAL |
CyrusNajmabadi
approved these changes
Mar 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #72258