Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IEmbeddedLanguageClassificationService is optional in the workspaces layer #72712

Merged
merged 1 commit into from
Mar 26, 2024
Merged

IEmbeddedLanguageClassificationService is optional in the workspaces layer #72712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Workspaces/Core/Portable/Classification/Classifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ internal static PooledObject<SegmentedList<ClassifiedSpan>> GetPooledList(out Se
{
var projectServices = services.GetLanguageServices(semanticModel.Language);
var classificationService = projectServices.GetRequiredService<ISyntaxClassificationService>();
var embeddedLanguageService = projectServices.GetRequiredService<IEmbeddedLanguageClassificationService>();

var syntaxClassifiers = classificationService.GetDefaultSyntaxClassifiers();

Expand All @@ -94,8 +93,12 @@ internal static PooledObject<SegmentedList<ClassifiedSpan>> GetPooledList(out Se
classificationService.AddSemanticClassifications(semanticModel, textSpan, getNodeClassifiers, getTokenClassifiers, semanticClassifications, options, cancellationToken);

// intentionally adding to the semanticClassifications array here.
if (includedEmbeddedClassifications && project != null)
if (includedEmbeddedClassifications
&& project != null
&& projectServices.GetService<IEmbeddedLanguageClassificationService>() is { } embeddedLanguageService)
{
embeddedLanguageService.AddEmbeddedLanguageClassifications(services, project, semanticModel, textSpan, options, semanticClassifications, cancellationToken);
}

var allClassifications = new List<ClassifiedSpan>(semanticClassifications.Where(s => s.TextSpan.OverlapsWith(textSpan)));
var semanticSet = semanticClassifications.Select(s => s.TextSpan).ToSet();
Expand Down
Loading