Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEmbeddedLanguageClassificationService is optional in the workspaces layer #72712

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

sharwell
Copy link
Member

The default implementation of IEmbeddedLanguageClassificationService is provided in the features layer, so make sure it is consumed as optional in the workspaces layer.

Fixes #63921

…layer

The default implementation of IEmbeddedLanguageClassificationService is
provided in the features layer, so make sure it is consumed as optional
in the workspaces layer.

Fixes dotnet#63921
@sharwell sharwell requested a review from a team as a code owner March 25, 2024 15:49
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 25, 2024
@sharwell sharwell merged commit 963f3a2 into dotnet:main Mar 26, 2024
27 checks passed
@sharwell sharwell deleted the optional-service branch March 26, 2024 12:47
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 26, 2024
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrading Microsoft.CodeAnalysis.CSharp.Workspace from 4.2.0 to 4.3.0 it started throwing at runtime
4 participants