Store and display the times when files were generated. #72724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 25, 2024
| @@ -325,7 +333,8 @@ private partial class CompilationTracker : ICompilationTracker | |||
| generatedSource.SyntaxTree.Options, | |||
| ProjectState.LanguageServices, | |||
| // Compute the checksum on demand from the given source text. | |||
| originalSourceTextChecksum: null)); | |||
| originalSourceTextChecksum: null, | |||
| generationDateTime)); | |||
There was a problem hiding this comment.
these are the places in the system where the generation actually happens, and so we record the time it happened as well. From this point on, this just flows outwards to be read and stored and eventually shown in the UI.
|
@genlu ptal. |
|
Oh man, do we have the ability to put a "re-run now" button in that? |
sharwell
reviewed
Mar 25, 2024
...s/Core/Portable/Workspace/Solution/SolutionCompilationState.CompilationTracker_Generators.cs
Show resolved
Hide resolved
We can def do that. I'll do it in the PR where we add 'balanced' mode. |
|
@dibarbet ptal |
sharwell
approved these changes
Mar 26, 2024
ToddGrun
reviewed
Mar 26, 2024
| @@ -281,6 +283,9 @@ private partial class CompilationTracker : ICompilationTracker | |||
| } | |||
|
|
|||
| using var generatedDocumentsBuilder = TemporaryArray<SourceGeneratedDocumentState>.Empty; | |||
|
|
|||
| // Capture the date now. We want all the generated files to use this date consistently. | |||
| var generationDateTime = DateTime.Now; | |||
There was a problem hiding this comment.
will update in followup.
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like:
This will be useful as we allow users to move to a model where generators don't run automatically, letting them when the generator was last run.