Handle razor @: transitions as comments
#72745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Razor, `@:` represents an unconditional transition to HTML for the rest of a given line. In order to handle this gracefully when using the C# lexer in Razor, we'll take the same approach we did for `@* *@` comments, except this time treating it as if it was a `//` comment.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler @CyrusNajmabadi for review. |
333fred
commented
Mar 26, 2024
src/Compilers/CSharp/Test/Syntax/LexicalAndXml/LexicalErrorTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 26, 2024
3 tasks
RikkiGibson
approved these changes
Mar 27, 2024
|
@dotnet/roslyn-compiler for a second review. |
RikkiGibson
approved these changes
Mar 27, 2024
jjonescz
reviewed
Mar 28, 2024
| public void CS1035AtColonParsedAsComment_02() | ||
| { | ||
| var test = """ | ||
| @:<div>test</div> |
There was a problem hiding this comment.
Today in Razor you can "spill" this markup transition over multiple lines via something like this:
@:@{<strong>
I'm evil
</strong>}Will that still work with the single-line comment lexing?
(I think we don't have to support that as it's not useful except for some hacks like dotnet/razor#7681 (comment).)
There was a problem hiding this comment.
It will "work" in that the first line will entirely be processed as a comment, and the next line will be treated as an identifier. We'll have to have tests for this and handle it carefully on the razor side.
jjonescz
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Razor,
@:represents an unconditional transition to HTML for the rest of a given line. In order to handle this gracefully when using the C# lexer in Razor, we'll take the same approach we did for@* *@comments, except this time treating it as if it was a//comment.