Prefer semantic classifications over syntactic ones when both occur at the same location

[CyrusNajmabadi]

No description provided.

[sharwell]

In addition to the changes seen here, we need to fix the definitions in ClassificationTypeDefinitions.cs. Semantic classifications for identifiers, e.g. UserTypeClassesTypeDefinition, need to have their BaseDefinition set to either Identifier or something derived from Identifier. Otherwise, if you remove Identifier from the classifications here, there will be no way for the system to know how to inherit colors if the semantic classification does not have a customized color set.

During a partial review, all of the references I have seen to PredefinedClassificationTypeNames.FormalLanguage in that file are incorrect, except for possibly the overlay styles (reassigned variables, obsolete, and static symbols).

[CyrusNajmabadi]

In addition to the changes seen here, we need to fix the definitions in ClassificationTypeDefinitions.cs. Semantic classifications for identifiers, e.g. UserTypeClassesTypeDefinition, need to have their BaseDefinition set to either Identifier or something derived from Identifier.

Done.

Feedback addressed

[CyrusNajmabadi]

@sharwell @ToddGrun ptal :)

[ToddGrun]