Move to collection exprs #73009
Merged
Move to collection exprs #73009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@ToddGrun ptal |
ToddGrun
reviewed
Apr 13, 2024
| @@ -17,7 +17,7 @@ internal static void UpdateText(SourceText newText, ITextBuffer buffer, EditOpti | |||
| var oldSnapshot = buffer.CurrentSnapshot; | |||
| var oldText = oldSnapshot.AsText(); | |||
| var changes = newText.GetTextChanges(oldText); | |||
| UpdateText(changes.ToImmutableArray(), buffer, oldSnapshot, oldText, options); | |||
| UpdateText([.. changes], buffer, oldSnapshot, oldText, options); | |||
There was a problem hiding this comment.
it rewrites it to:
int num = 0;
TextChange[] array = new TextChange[readOnlyList.Count];
foreach (TextChange item in readOnlyList)
{
array[num] = item;
num++;
}
UpdateText(ImmutableCollectionsMarshal.AsImmutableArray(array), buffer, oldSnapshot, oldText, options);which is basically ideal here.
There was a problem hiding this comment.
Doesn't the old code not allocate since changes is actually an ImmutableArray?
public static ImmutableArray<TSource> ToImmutableArray<TSource>(this IEnumerable<TSource> items)
{
if (items is ImmutableArray<TSource>)
{
return (ImmutableArray<TSource>)items;
}
return CreateRange(items);
}
There was a problem hiding this comment.
Oh I see. This benefitted from a runtime check. That's a tougher call. Will have to think about that.
There was a problem hiding this comment.
Talked with Cyrus about this, and while there is a new allocation here, he's ran perf tests and no regressions appear at that level. Additionally, he's indicated that this particular regression is something that is being investigated to see if it can be addressed at the collection expression level. Not going to block anymore based on this.
ToddGrun
reviewed
Apr 13, 2024
ToddGrun
reviewed
Apr 13, 2024
src/EditorFeatures/Core/IntelliSense/AsyncCompletion/CompletionSource.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 13, 2024
ToddGrun
reviewed
Apr 19, 2024
| @@ -45,7 +45,7 @@ public override ITypeSymbol VisitNamedType(INamedTypeSymbol symbol) | |||
| return symbol; | |||
| } | |||
|
|
|||
| return symbol.ConstructedFrom.Construct(arguments.ToArray()); | |||
| return symbol.ConstructedFrom.Construct([.. arguments]); | |||
ToddGrun
reviewed
Apr 19, 2024
| @@ -47,7 +47,7 @@ public override ITypeSymbol VisitNamedType(INamedTypeSymbol symbol) | |||
| if (arguments.SequenceEqual(symbol.TypeArguments)) | |||
| return symbol; | |||
|
|
|||
| return symbol.ConstructedFrom.Construct(arguments.ToArray()); | |||
| return symbol.ConstructedFrom.Construct([.. arguments]); | |||
ToddGrun
reviewed
Apr 19, 2024
| @@ -49,7 +49,7 @@ public override ITypeSymbol VisitNamedType(INamedTypeSymbol symbol) | |||
| return symbol; | |||
| } | |||
|
|
|||
| return symbol.ConstructedFrom.Construct(arguments.ToArray()); | |||
| return symbol.ConstructedFrom.Construct([.. arguments]); | |||
ToddGrun
reviewed
Apr 19, 2024
| @@ -151,7 +151,7 @@ public async Task WaitAllAsync(Workspace? workspace, string[]? featureNames = nu | |||
| do | |||
| { | |||
| // wait for all current tasks to be done for the time given | |||
| if (Task.WaitAll(tasks.ToArray(), smallTimeout)) | |||
| if (Task.WaitAll([.. tasks], smallTimeout)) | |||
|
Will do in follow ups! |
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR1: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=9445152&view=results
PR2: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=9445153&view=results