Do not report exception message in fault details #73034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Apr 15, 2024
| // If we couldn't get a stack, do this | ||
| return exception.Message; | ||
| // If we couldn't get a stack, report a generic message. | ||
| // The exception message is already reported in a separate cred-scanned property. |
There was a problem hiding this comment.
the fault description field is not client side cred-scanned by VS telemetry. We should not report the message again here, there is already an exception message property that is cred-scanned.
dibarbet
commented
Apr 15, 2024
| @@ -78,10 +78,9 @@ internal static bool ResetRenameTrackingStateWorker(Workspace workspace, Documen | |||
| if (textBuffer == null) | |||
| { | |||
| var ex = new InvalidOperationException(string.Format( | |||
| "document with name {0} is open but textBuffer is null. Textcontainer is of type {1}. SourceText is: {2}", | |||
| "document with name {0} is open but textBuffer is null. Textcontainer is of type {1}.", | |||
There was a problem hiding this comment.
This isn't 100% necessary to resolve the bug given we also have the change below (and assuming the message field is cred scanned), but in general we shouldn't be reporting the full source in fault telemetry.
CyrusNajmabadi
approved these changes
Apr 15, 2024
arkalyanms
approved these changes
Apr 15, 2024
This was referenced Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of fixes for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2032081