Followup work to handle ForegroundThreadAffinitizedObject removal. #73049
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -146,75 +146,15 @@ private static string GetFixCategory(DiagnosticSeverity severity) | |||
| throw new NotImplementedException($"We implement {nameof(GetSuggestedActionCategoriesAsync)}. This should not be called."); | |||
| } | |||
|
|
|||
| private async Task<TextSpan?> GetSpanAsync(ReferenceCountedDisposable<State> state, SnapshotSpan range, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
this was some overwrought code to get the user's selection. inlined to callsite.
| await _threadingContext.InvokeBelowInputPriorityAsync(() => | ||
| { | ||
| // Make sure we were not disposed between kicking off this work and getting to this point. | ||
| using var state = _state.TryAddReference(); |
There was a problem hiding this comment.
@sharwell it feels like this was unnecessary (and was not ported to callsite). taht code already is holding onto the state in a local, so the ref count can't go away while we're switching to teh UI to get the selection.
| @@ -70,7 +70,7 @@ private partial class SuggestedActionsSource : IAsyncSuggestedActionsSource | |||
| CancellationToken cancellationToken) | |||
| { | |||
| _threadingContext.ThrowIfNotOnUIThread(); | |||
| using var state = SourceState.TryAddReference(); | |||
| using var state = _state.TryAddReference(); | |||
There was a problem hiding this comment.
remove this property that did nothing more than return the state.
|
|
||
| private static string GetFixCategory(DiagnosticSeverity severity) |
There was a problem hiding this comment.
called in only one location. inlined.
| { | ||
| using var state = _state.TryAddReference(); |
There was a problem hiding this comment.
no need to grab this again. it can be passed in.
src/EditorFeatures/Core.Wpf/Suggestions/SuggestedActionsSource.cs
Outdated
Show resolved
Hide resolved
| @@ -140,6 +140,21 @@ void FireEventsForDocument(DocumentId documentId) | |||
| codeModel.FireEvents(); | |||
| return; | |||
| } | |||
|
|
|||
| // Returns true if any keyboard or mouse button input is pending on the message queue. | |||
| static bool IsInputPending() | |||
There was a problem hiding this comment.
only called here. moved to this location.
|
@sharwell this is ready for review. |
|
@sharwell ptal. |
|
@sharwell ptal |
src/EditorFeatures/Core.Wpf/Suggestions/SuggestedActionsSource.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Suggestions/SuggestedActionsSource.cs
Outdated
Show resolved
Hide resolved
|
@jasonmalinowski For review when you get back. |
Fixes #73048.
Followup to #73029.