Use 'nullable disabled' semantic model when computing FAR results #73078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 18, 2024
|
|
||
| public readonly Document Document; | ||
| public readonly SemanticModel SemanticModel; | ||
| public readonly SyntaxNode Root; |
There was a problem hiding this comment.
had this hold onto Doc/SemanticModel/Root to ease up on hte number of arguments i'm passing around later.
CyrusNajmabadi
commented
Apr 18, 2024
| FindReferenceCache cache, | ||
| HashSet<string>? globalAliases) | ||
| { | ||
| private static readonly HashSet<string> s_empty = []; | ||
|
|
||
| public readonly Document Document = document; | ||
| public readonly SemanticModel SemanticModel = semanticModel; | ||
| public readonly SyntaxNode Root = root; |
There was a problem hiding this comment.
instead of individual fields, this is obtainable from the cache.
ToddGrun
reviewed
Apr 18, 2024
src/Workspaces/Core/Portable/FindSymbols/FindReferences/FindReferencesSearchEngine.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traces show upwards of 15% of our time in nullability analysis for these features: