Include file name in Contract failures #73092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the file names to the messages generated by contract failures. This information would've made it _significantly_ easier to debug a recent DDRIT failure.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@CyrusNajmabadi want to make sure you saw this PR as you added the |
jaredpar
commented
Apr 18, 2024
| @@ -48,11 +49,11 @@ internal static partial class Contract | |||
| /// all builds | |||
| /// </summary> | |||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
| public static void ThrowIfNull<T>([NotNull] T value, string message, [CallerLineNumber] int lineNumber = 0) | |||
| public static void ThrowIfNull<T>([NotNull] T value, string message, [CallerLineNumber] int lineNumber = 0, [CallerFilePath] string? filePath = null) | |||
There was a problem hiding this comment.
Note: the filePath is last specifically to avoid ambiguities with Contract methods that take an explicit string message like this one.
ryzngard
approved these changes
Apr 18, 2024
|
Sounds great! |
CyrusNajmabadi
approved these changes
Apr 19, 2024
|
What was the error btw? |
3 tasks
|
Test failure is a known flaky issue. |
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the file names to the messages generated by contract failures. This information would've made it significantly easier to debug a recent DDRIT failure.