Change IReferenceFinder.DetermineDocumentsToSearchAsync to not return an ImmutableArray #73093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an ImmutableArray Rather, this method now encourages items that wish to be part of the result to invoke a callback with that result. This prevents quite a few intermediary array allocations during find references invocations.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -190,6 +190,8 @@ private async Task ProcessProjectAsync(Project project, ImmutableArray<ISymbol> | |||
| using var _2 = PooledDictionary<Document, MetadataUnifyingSymbolHashSet>.GetInstance(out var documentToSymbols); | |||
| try | |||
| { | |||
| using var _3 = ArrayBuilder<Document>.GetInstance(out var documents); | |||
There was a problem hiding this comment.
maybe doc semantics. call it documentsBuffer indicating it will be reset/cleared on iterations?
| @@ -43,20 +46,18 @@ protected override bool CanFind(IMethodSymbol symbol) | |||
|
|
|||
| var underlyingNamedType = GetUnderlyingNamedType(symbol.ReturnType); | |||
| Contract.ThrowIfNull(underlyingNamedType); | |||
| var documentsWithName = await FindDocumentsAsync(project, documents, cancellationToken, underlyingNamedType.Name).ConfigureAwait(false); | |||
| var documentsWithType = await FindDocumentsAsync(project, documents, underlyingNamedType.SpecialType.ToPredefinedType(), cancellationToken).ConfigureAwait(false); | |||
|
|
|||
| using var _ = ArrayBuilder<Document>.GetInstance(out var result); | |||
There was a problem hiding this comment.
nit (and you're preserving logic, so up to you), but chaneg this to a pooled hashset. it was an array before to keep all the sigs the same. but now that this is callbac style, this can change.
CyrusNajmabadi
approved these changes
Apr 18, 2024
…shset to allow unique-doc semantics
| using var _ = ArrayBuilder<Document>.GetInstance(out var result); | ||
| using var _ = PooledHashSet<Document>.GetInstance(out var result); | ||
| await FindDocumentsAsync(project, documents, static (doc, result) => result.Add(doc), result, cancellationToken, underlyingNamedType.Name).ConfigureAwait(false); | ||
| await FindDocumentsAsync(project, documents, underlyingNamedType.SpecialType.ToPredefinedType(), static (doc, result) => result.Add(doc), result, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
nit. ont thing i've been thinking about is the repetition of things like static (doc, result) => result.Add(doc). Consider a protected static in the topmost type like Action<...> StandardAddCallback and reference those here. (may not work due to genercs).
There was a problem hiding this comment.
Went ahead and made that change (I like the idea, but these were the only ones I could find).
...Workspaces/Core/Portable/FindSymbols/FindReferences/Finders/OrdinaryMethodReferenceFinder.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ToddGrun
added a commit
to ToddGrun/roslyn
that referenced
this pull request
Apr 20, 2024
…ations> created during find references invocations. This is very similar to this PR (dotnet#73093) that did the same thing for ImmutableArray<Document> in this context.
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather, this method now utilizes a callback to be invoked with results. This prevents quite a few intermediary array allocations during find references invocations.