Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused async entrypoints #73116

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Remove unused async entrypoints #73116

merged 2 commits into from
Apr 20, 2024

Conversation

CyrusNajmabadi
Copy link
Member

These entrypoints were only used in tests.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 20, 2024 00:35
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 20, 2024
ToddGrun
ToddGrun reviewed Apr 20, 2024
View reviewed changes
src/Workspaces/CoreTest/WorkspaceServiceTests/TemporaryStorageServiceTests.cs
@@ -60,8 +60,8 @@ public void TestTemporaryStorageStream()
}

data.Position = 0;
temporaryStorage.WriteStreamAsync(data).Wait();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Wait();

Even for test code, that's ugly

ToddGrun
ToddGrun approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 2c0668d into dotnet:main Apr 20, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 20, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the removeAsync branch April 20, 2024 02:35
This was referenced Apr 23, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet