Remove parameter which was always passed the same value #73198
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -24,7 +24,7 @@ internal partial class DiagnosticIncrementalAnalyzer | |||
| /// Return all diagnostics that belong to given project for the given StateSets (analyzers) either from cache or by calculating them | |||
| /// </summary> | |||
| private async Task<ProjectAnalysisData> GetProjectAnalysisDataAsync( | |||
| CompilationWithAnalyzers? compilationWithAnalyzers, Project project, IdeAnalyzerOptions ideOptions, ImmutableArray<StateSet> stateSets, bool forceAnalyzerRun, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
this function was always passed 'true' for 'forceAnalyzerRun'. I removed the parameter, and collapsed all the control flow accordingly.
| fullAnalysisEnabled = true; | ||
| compilerFullAnalysisEnabled = true; | ||
| analyzersFullAnalysisEnabled = true; | ||
| } |
There was a problem hiding this comment.
since forceAnalyzerRun, these 3 values were always true.
| analyzersFullAnalysisEnabled = true; | ||
| } | ||
|
|
||
| if (!fullAnalysisEnabled) |
There was a problem hiding this comment.
since fullAnalysisEnabled was always true (due to forceAnalyzerRun being true), this block was never run.
|
|
||
| // Reduce the state sets to analyze based on individual full solution analysis values | ||
| // for compiler diagnostics and analyzers. | ||
| if (!compilerFullAnalysisEnabled) |
There was a problem hiding this comment.
same for these two conditions.
| @@ -179,8 +122,8 @@ private static bool CompilationHasOpenFileOnlyAnalyzers(CompilationWithAnalyzers | |||
| if (compilationWithAnalyzers?.Analyzers.Length > 0) | |||
| { | |||
| // calculate regular diagnostic analyzers diagnostics | |||
| var resultMap = await _diagnosticAnalyzerRunner.AnalyzeProjectAsync(project, compilationWithAnalyzers, | |||
| forcedAnalysis, logPerformanceInfo: false, getTelemetryInfo: true, cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
that value eventually flowed into this AnalyzeProjectAsync call. This is the only place in teh product (not tests) where this method is called. so the parameter got removed here as well.
| bool logPerformanceInfo, | ||
| bool getTelemetryInfo, | ||
| CancellationToken cancellationToken) | ||
| => AnalyzeAsync(documentAnalysisScope: null, project, compilationWithAnalyzers, | ||
| isExplicit: false, forceExecuteAllAnalyzers, logPerformanceInfo, getTelemetryInfo, cancellationToken); | ||
| isExplicit: false, forceExecuteAllAnalyzers: true, logPerformanceInfo, getTelemetryInfo, cancellationToken); |
There was a problem hiding this comment.
the parameter was passed in here, as AnalyzeAsync is called from AnalyzeDocumentAsync above, which passesin in 'false' for this value.
| @@ -192,11 +192,7 @@ void Method() | |||
| analyzerReference.GetAnalyzers(project.Language).Where(a => a.GetType() == analyzerType).ToImmutableArray(), | |||
| new WorkspaceAnalyzerOptions(project.AnalyzerOptions, ideAnalyzerOptions)); | |||
|
|
|||
| // no result for open file only analyzer unless forced | |||
| var result = await runner.AnalyzeProjectAsync(project, compilationWithAnalyzers, forceExecuteAllAnalyzers: false, logPerformanceInfo: false, getTelemetryInfo: false, cancellationToken: CancellationToken.None); | |||
| Assert.Empty(result.AnalysisResult); | |||
There was a problem hiding this comment.
this test validated behavior that the product never ran into.
No description provided.