Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose XAML IDiagnosticSourceProvider names #73674

Merged
merged 1 commit into from
May 23, 2024
Merged

Expose XAML IDiagnosticSourceProvider names #73674

merged 1 commit into from
May 23, 2024

Conversation

etvorun
Copy link
Contributor

@etvorun etvorun commented May 23, 2024

Expose names of XAML IDiagnosticSourceProvider's so that they can be referenced during XAML Language Service registration

@etvorun etvorun requested a review from a team as a code owner May 23, 2024 19:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 23, 2024
mgoertz-msft
mgoertz-msft approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@mgoertz-msft mgoertz-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the existing StringConstants here? It's a bit odd to have two places.

@dibarbet dibarbet merged commit 02ca493 into dotnet:main May 23, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 23, 2024
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
This was referenced Jun 4, 2024
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

@mgoertz-msft mgoertz-msft mgoertz-msft approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@etvorun @dibarbet @mgoertz-msft @Cosifne