Don't run code in the async/await highlighter unless on one of those keywords.

[CyrusNajmabadi]

Addresses about half the cost of keyword highlighting.

[CyrusNajmabadi]

@ToddGrun ptal.

[CyrusNajmabadi]

no point going into trivia for most highlighters. can update others as appropraite.

[CyrusNajmabadi]

the async/await highlighter si not well written. it does all sorts of unnecessary work even when not on an appropraite keyword. this allows us to early bail out here and not do any of that work.

[CyrusNajmabadi]

i picked the highlighters to update based on if i saw the in the traces.

[ToddGrun]

        tokens.Add(token);

dumb question:

Could this method to also handle the _findInsideTrivia case and use the FindToken results so it wouldn't need to walk the as much of the tree for the _findInsideTrivia case, or is that more complexity than it's worth? ie, something like:

var token = root.FindToken(position, findInsideTrivia: false);
if (!tokens.Contains(token))
    tokens.Add(token);

if (_findInsideTrivia)
{
    token = token.Parent.FindToken(position, findInsideTrivia: true);
    if (!tokens.Contains(token))
        tokens.Add(token);    
}  
...

---

Refers to: src/Features/Core/Portable/Highlighting/Keywords/AbstractKeywordHighlighter.cs:94 in b7594de. [](commit_id = b7594de, deletion_comment = False)

[ToddGrun]

SyntaxKind.SemicolonToken

Can you clarify what this means in practice? If a semicolon is at the caret position, this highlighter will always be asked?

[CyrusNajmabadi]

yes. that's correct. that's because the loop highlighter will highlight if you're next to things like break; that's ok. this is still a tiny subset of all tokens.

[CyrusNajmabadi]

the main goal here is to stop runnin all these highlighters unnecessarily on tokens they will never report results for. that's just pointless.

[CyrusNajmabadi]

Could this method to also handle the _findInsideTrivia case and use the FindToken results so it wouldn't need to walk the as much of the tree for the _findInsideTrivia case, or is that more complexity than it's worth? ie, something like:

It definitely could/should. But baby steps based on traces :)

[ToddGrun]

Fair enough, doesn't hurt to ask :)

---

In reply to: 2132367763

[ToddGrun]