Normalize paths when generating pipe names #8504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @dotnet/roslyn-compiler |
|
@dotnet/roslyn-compiler please review. Small change. Promise :) |
| internal static string GetBasePipeName(string compilerExeDirectory) | ||
| { | ||
| // Normalize away trailing slashes. File APIs include / exclude this with no | ||
| // discernable pattern. Easiest to normalize it here vs. auditing every inputt |
There was a problem hiding this comment.
Typo at input. But perhaps change to every caller of this method instead.
jaredpar
force-pushed
the
fix
branch
2 times, most recently
from
cb884a9
to
62ebaae
Compare
|
Updated to address feedback |
|
LGTM |
|
👍 |
| [Fact] | ||
| public void GetBasePipeNameSlashes() | ||
| { | ||
| var path = @"q:\the\path"; |
There was a problem hiding this comment.
What about separators here?
It turns out APIs are very inconsistent in whether they leave a trailing directory separator on path names. This caused the client and server code to generate different pipe names for the same file location. Hence VbcsCompiler -shutdown was failing because it used the wrong pipe name. Fix this by normalizing path names.
jaredpar
added a commit
that referenced
this pull request
Feb 12, 2016
Normalize paths when generating pipe names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out APIs are very inconsistent in whether they leave a trailing directory separator on path names. This caused the client and server code to generate different pipe names for the same file location. Hence VbcsCompiler -shutdown was failing because it used the wrong pipe name. Fix this by normalizing path names.