Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeGen: Clarify the naming and usage of consumeReg methods #12179

Open
CarolEidt opened this issue Mar 4, 2019 · 0 comments
Open

CodeGen: Clarify the naming and usage of consumeReg methods #12179

CarolEidt opened this issue Mar 4, 2019 · 0 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI documentation Documentation bug or enhancement, does not impact product or test code help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@CarolEidt
Copy link
Contributor

The naming and usage of the various consumeReg methods is not clearly articulated anywhere. Their usage should probably be documented in codegen.h where they are declared.
This came up in the discussion of dotnet/coreclr#22944

category:implementation
theme:jit-coding-style
skill-level:beginner
cost:medium
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@BruceForstall BruceForstall added help wanted [up-for-grabs] Good issue for external contributors and removed JitUntriaged CLR JIT issues needing additional triage labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI documentation Documentation bug or enhancement, does not impact product or test code help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@CarolEidt @msftgits @BruceForstall