-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVL Tree in ImmutableList not always balanced after insert #13883
Comments
@PatrickMcDonald Can you please revise your commit message to conform with the format described here? In particular, we want the first line to be a description of the actual change (80 chars or less) followed by a blank line and additional paragraphs as necessary. Your last line can be "Fixes dotnet/corefx#103" so that github associates the the commit with the issue. You can revise your commit using |
This wasn't merged but closed by a bot? |
@forki Issue was closed, but PR was merged |
When Insert is called in ImmutableList, the list is not always balanced correctly by the MakeBalanced method. This was exposed PR dotnet/corefx#67. I have created a minimal test which exposes this bug and will create a separate PR to correct this.
The text was updated successfully, but these errors were encountered: