Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVL Tree in ImmutableList not always balanced after insert #13883

Closed
PatrickMcDonald opened this issue Nov 16, 2014 · 3 comments
Closed

AVL Tree in ImmutableList not always balanced after insert #13883

PatrickMcDonald opened this issue Nov 16, 2014 · 3 comments
Milestone

Comments

@PatrickMcDonald
Copy link
Contributor

When Insert is called in ImmutableList, the list is not always balanced correctly by the MakeBalanced method. This was exposed PR dotnet/corefx#67. I have created a minimal test which exposes this bug and will create a separate PR to correct this.

PatrickMcDonald referenced this issue in PatrickMcDonald/corefx Nov 16, 2014
@AArnott
Copy link
Contributor

AArnott commented Nov 16, 2014

@PatrickMcDonald Can you please revise your commit message to conform with the format described here?

In particular, we want the first line to be a description of the actual change (80 chars or less) followed by a blank line and additional paragraphs as necessary. Your last line can be "Fixes dotnet/corefx#103" so that github associates the the commit with the issue.

You can revise your commit using git commit --amend and then doing a forced push to your branch.

@forki
Copy link

forki commented Nov 17, 2014

This wasn't merged but closed by a bot?
Is this correct?

@PatrickMcDonald
Copy link
Contributor Author

@forki Issue was closed, but PR was merged

Olafski referenced this issue in Olafski/corefx Jun 15, 2017
Use dotnet command to run binary
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants