Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.IdentityModel: status, governance and API convergence #18945

Closed
kevinchalet opened this issue Oct 13, 2016 · 7 comments
Closed

System.IdentityModel: status, governance and API convergence #18945

kevinchalet opened this issue Oct 13, 2016 · 7 comments
Labels
area-Meta question Answer questions and provide assistance, not an issue with source code or documentation. tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Milestone

Comments

@kevinchalet
Copy link
Contributor

Disclaimer: I'm well aware that the IdentityModel stack is managed by the Azure AD team and not by the FX team and that related tickets should be opened elsewhere. Unfortunately, it seems to be in a pretty bad state these days: the activity is terribly low for such an important stack, critical bugs are not fixed and there's literally no plan for API convergence. By opening a ticket here, I hope this ticket will draw more attention from MSFT.

So here are my questions:

  • Is there any plan to realign IdentityModel for .NET Core with its .NET Desktop counterpart as part of API convergence/.NET Standard 2.0? The .NET Core version lacks many important APIs compared to the .NET Desktop bits (it's basically a simple port of the JWT handler plus a bunch of other types that were needed for things like the OpenID Connect middleware for ASP.NET Core to work correctly).
  • Can you share an approximative timeline for fixing the critical bugs? A few annoying bugs were reported in July/August and are still in need of an urgent fix (e.g this bug).
  • Will IdentityModel for .NET Desktop get updates in the future? I'm mainly interested in knowing if it will ever support RSACng and ECDSA.

It's quite obvious that the Azure AD team doesn't currently have the human resources needed to manage such an important stack. Maybe it would be worth considering assigning new developers to IdentityModel or transferring its ownership to another team? It seems that the WCF team is currently relying on private IdentityModel bits to make WCF work, maybe they would be interested in collaborating to IM?

/cc @vibronet @polita @brentschmaltz

@danmoseley
Copy link
Member

@terrajobst

@kevinchalet
Copy link
Contributor Author

@blowdart admit it, you couldn't resist :trollface:

That said, my third question still has no answer.

@polita
Copy link

polita commented Oct 24, 2016

@PinpointTownes Sorry, we don't have a GitHub repo for WCF. RSACng support has been added to WCF 4.6.3.

@blowdart
Copy link
Contributor

I did check with @polita first before closing, which was how I got the issues.

@kevinchalet
Copy link
Contributor Author

@PinpointTownes Sorry, we don't have a GitHub repo for WCF. RSACng support has been added to WCF 4.6.3.

Just to make sure we're talking about the same thing, by RSACng support, I mean in code paths like this one: https://referencesource.microsoft.com/#System.IdentityModel/System/IdentityModel/Tokens/RsaSecurityKey.cs,210 (as you can see, it's not WCF-specific)

@brentschmaltz
Copy link

@PinpointTownes Similar to this issue: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#480, I think IdentityModel needs a 4.6.2 target. For 4.6.1 and below, if RSA is not an RSACryptoServiceProvider, we have to throw OR have a later failure.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta question Answer questions and provide assistance, not an issue with source code or documentation. tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Projects
None yet
Development

No branches or pull requests

6 participants