Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2: Remove redundancy in running remote server tests #30205

Open
geoffkizer opened this issue Jul 9, 2019 · 1 comment
Open

HTTP2: Remove redundancy in running remote server tests #30205

geoffkizer opened this issue Jul 9, 2019 · 1 comment
Labels
area-System.Net.Http test-enhancement Improvements of test source code
Milestone

Comments

@geoffkizer
Copy link
Contributor

Many remote server tests are defined in classes like HttpClientHandlerTest.cs, which get subclassed three times:

PlatformHandler, HTTP/1.1 loopback server
SocketsHttpHandler, HTTP/1.1 loopback server
SocketsHttpHandler, HTTP/2 loopback server

As a result, remote server tests in these files are running twice for SocketsHttpHandler. (Note loopback server is unused in these tests, and thus the loopback server version does not matter. These tests will run HTTP/1.1 or HTTP/2 depending on the remote server itself.)

We should get rid of this redundancy by moving remote server tests into separate classes that don't derive multiple subclasses for different HTTP versions.

Additional thoughts:

It might be nice to actually have a separate base class for remote server test classes. This would help clear up confusion with some of the stuff in HttpClientHandlerTestBase that's not actually used for remote server tests, e.g. the HTTP2 setting, etc.

See original discussion in #30133

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@karelz karelz modified the milestones: 5.0, Future May 7, 2020
@geoffkizer
Copy link
Contributor Author

Note this will get worse with HTTP3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net.Http test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

3 participants