Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multi job helix project to support multiple test modes on CI #36215

Open
steveisok opened this issue May 11, 2020 · 6 comments
Open

Create multi job helix project to support multiple test modes on CI #36215

steveisok opened this issue May 11, 2020 · 6 comments

Comments

@steveisok
Copy link
Member

As discussed in #35568 (review), we need to construct a multi job helix project that calls into sendtohelix.proj with different variables and in parallel.

A good example for this approach would be the mono interpreter. Since it is built within every mono runtime, it can be enabled with the --interpreter parameter. It would be wasteful of CI resources to do this independently of a regular mono test run, so shuffling different parameters into sendtohelix.proj would do the trick.

On the yml side, we would need to trigger the multi job helix project:

steps:
- script: ${{ parameters.msbuildScript }}
$(Build.SourcesDirectory)/src/libraries/sendtohelix.proj
/t:test
/p:RuntimeFlavor=${{ parameters.runtimeFlavor }}
/p:TargetArchitecture=${{ parameters.archGroup }}
/p:Configuration=${{ parameters.configuration }}
/p:TargetOS=${{ parameters.targetOS }}
/p:TestScope=${{ parameters.testScope }}
/p:TestRunNamePrefixSuffix=${{ parameters.testRunNamePrefixSuffix }}
/p:HelixBuild=$(Build.BuildNumber)
/p:Creator=${{ parameters.creator }}
${{ parameters.extraHelixArguments }}
/bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/SendToHelix.binlog

And then within the multi job helix project, we would shuffle different parameters to sendtohelix.proj as it exists today.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels May 11, 2020
@steveisok steveisok added area-Infrastructure-libraries and removed area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels May 11, 2020
@ghost
Copy link

ghost commented May 11, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer
Copy link
Member

I believe the tracking work is already implemented. cc @safern

@safern
Copy link
Member

safern commented Jul 27, 2020

The work to achieve this is already implemented, however we still need to move interpreter leg to the regular leg and use that mechanism still.

@steveisok
Copy link
Member Author

/cc @directhex

@ViktorHofer
Copy link
Member

@steveisok moving to infrastructure-mono as the remaining work is updating the interpreter leg to use the new mechanism.

@ghost
Copy link

ghost commented Jul 30, 2020

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

@steveisok steveisok modified the milestones: 5.0.0, 6.0.0 Aug 14, 2020
@steveisok steveisok modified the milestones: 6.0.0, 7.0.0 Jul 26, 2021
@steveisok steveisok modified the milestones: 7.0.0, Future Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants