Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Proposal: Add PlatformID.Unknown value #38984

Closed
marek-safar opened this issue Jul 9, 2020 · 3 comments
Closed

API Proposal: Add PlatformID.Unknown value #38984

marek-safar opened this issue Jul 9, 2020 · 3 comments
Labels
api-approved API was approved in API review, it can be implemented arch-wasm WebAssembly architecture area-System.Runtime
Milestone

Comments

@marek-safar
Copy link
Contributor

Background and Motivation

With the addition of more platforms to dotnet/runtime the existing .NET Framework APIs are missing way to express them. Instead of duplicating logic between System.Runtime.InteropServices.RuntimeInformation API and old .NET Framework APIs we introduce generic undefined value for old APIs.

Proposed API

namespace System
{
    public enum PlatformID
    {
        MacOSX = 6,
+       Unknown = 7,
    }
@marek-safar marek-safar added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Jul 9, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 9, 2020
@marek-safar marek-safar added area-System.Runtime and removed untriaged New issue has not been triaged by the area owner labels Jul 9, 2020
@marek-safar marek-safar added this to the 5.0.0 milestone Jul 9, 2020
@marek-safar marek-safar added the arch-wasm WebAssembly architecture label Jul 9, 2020
@jkotas jkotas added api-ready-for-review API is ready for review, it is NOT ready for implementation blocking Marks issues that we want to fast track in order to unblock other important work and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation labels Jul 9, 2020
@bartonjs bartonjs added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for review, it is NOT ready for implementation blocking Marks issues that we want to fast track in order to unblock other important work labels Jul 9, 2020
@bartonjs
Copy link
Member

bartonjs commented Jul 9, 2020

Video

API review suggests that "Other" is a better name, since it is "known" to not be one of the other values.

namespace System
{
    public enum PlatformID
    {
        MacOSX = 6,
+       Other = 7,
    }

Additionally, if we haven't already done obsoletion plans for this enum and the things related to it, it's probably a good idea.

@marek-safar
Copy link
Contributor Author

Additionally, if we haven't already done obsoletion plans for this enum and the things related to it, it's probably a good idea.

I agree is that work is tracked elsewhere?

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented arch-wasm WebAssembly architecture area-System.Runtime
Projects
None yet
Development

No branches or pull requests

4 participants