Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSRA][RyuJIT] Tune register selection heuristics #43318

Closed
9 of 11 tasks
CarolEidt opened this issue Oct 12, 2020 · 1 comment
Closed
9 of 11 tasks

[LSRA][RyuJIT] Tune register selection heuristics #43318

CarolEidt opened this issue Oct 12, 2020 · 1 comment
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Bottom Up Work Not part of a theme, epic, or user story tenet-performance Performance related issue User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@CarolEidt
Copy link
Contributor

CarolEidt commented Oct 12, 2020

The current register allocation selection heuristics are less than optimal. At the very least, they result in poor selection in the face of heavy register pressure, as seen in #8846, and more broadly described in #6824.

The plan for addressing this is:

Future work

Additional issues that should be considered and/or addressed: #7999 (heuristics for incoming parameters), #7996 (include encoding size in heuristics, beyond REG_VAR_ORDER)

General register allocation issues that should be analyzed to determine if tuning the heuristics will address them:

category:cq
theme:register-allocator
skill-level:expert
cost:large

@CarolEidt CarolEidt added Epic Groups multiple user stories. Can be grouped under a theme. tenet-performance Performance related issue area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Oct 12, 2020
@CarolEidt CarolEidt added this to the 6.0.0 milestone Oct 12, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 12, 2020
@JulieLeeMSFT JulieLeeMSFT added this to Needs Triage in .NET Core CodeGen via automation Oct 12, 2020
@JulieLeeMSFT JulieLeeMSFT moved this from Needs Triage to Optimizations (RegAlloc/Struct) in .NET Core CodeGen Oct 12, 2020
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Oct 12, 2020
@JulieLeeMSFT JulieLeeMSFT added Team Epic and removed Epic Groups multiple user stories. Can be grouped under a theme. labels Oct 19, 2020
@JulieLeeMSFT JulieLeeMSFT moved this from Optimizations (RegAlloc/Struct) to Team Epics in .NET Core CodeGen Nov 2, 2020
@JulieLeeMSFT JulieLeeMSFT moved this from Team Epics to Needs Triage in .NET Core CodeGen Nov 9, 2020
@JulieLeeMSFT JulieLeeMSFT moved this from Needs Triage to Team Epics in .NET Core CodeGen Nov 9, 2020
@JulieLeeMSFT JulieLeeMSFT added User Story A single user-facing feature. Can be grouped under an epic. Bottom Up Work Not part of a theme, epic, or user story and removed Team Epic labels Nov 16, 2020
@CarolEidt CarolEidt removed their assignment Dec 4, 2020
@kunalspathak
Copy link
Member

Closing this as there are no more work items to be done in .NET 6.

.NET Core CodeGen automation moved this from Team Epics to Done Jul 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Bottom Up Work Not part of a theme, epic, or user story tenet-performance Performance related issue User Story A single user-facing feature. Can be grouped under an epic.
Projects
Archived in project
Development

No branches or pull requests

4 participants