-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembly.ReflectionOnlyLoad(...) is obsoleted, consider remove the unused reference in mono #51838
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @CoffeeFlux Issue DetailsAs part of #50529 we have obsoleted several APIs not supported in .Net Core which caused a build warning in mono CoreClr I see the API calling runtime/src/mono/System.Private.CoreLib/src/System/RuntimeTypeHandle.cs Lines 290 to 291 in 90f97ac
Originally posted by @buyaa-n in #50941 (comment)
|
Not sure what the best approach is for associated tests - completely remove from test suite or disable for certain runs. |
As part of #50529 we have obsoleted several APIs not supported in .Net Core which caused a build warning in mono CoreClr
I see the API calling
Assembly.ReflectionOnlyLoad(...)
is always called with a value offalse
forbool reflectionOnly
parameter, which means that reference will never actually used. We might want to remove this parameter and related code section fromruntime/src/mono/System.Private.CoreLib/src/System/RuntimeTypeHandle.cs
Lines 290 to 291 in 90f97ac
Originally posted by @buyaa-n in #50941 (comment)
The text was updated successfully, but these errors were encountered: