Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Su… #56338

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

danmoseley
Copy link
Member

@steveisok was hitting in P7 (eg #56255) as @karelz noted in #55774

cc @karelz

@ghost
Copy link

ghost commented Jul 26, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

@steveisok was hitting in P7 (eg #56255) as @karelz noted in #55774

cc @karelz

Author: danmoseley
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@wfurt
Copy link
Member

wfurt commented Jul 26, 2021

note that any test can fail because of #55979 (and perhaps others)
It seems like disabling tests one-by-one is whack-a-mole game.

Perhaps best action for P7 is to disable QUIC/H3 tests completely.

@danmoseley
Copy link
Member Author

Ah, interesting. I picked this one as it's what they hit and it was top of the query:

TestResults
| join kind=inner WorkItems on WorkItemId
| join kind=inner Jobs on JobId
| where Finished >= now(-1d)
| where Type == "System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic" //"ResponseCancellation_ServerReceivesCancellation"
| project Started, Duration, Type, Method, FriendlyName, MachineName, QueueName1, Message, StackTrace, Arguments, Branch
| summarize count() by Type, Method
Type Method count_
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic ClientSettingsReceived_Success 10
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic SendMoreThanStreamLimitRequests_Succeeds 1
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic ResponseCancellation_ServerReceivesCancellation 9
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic SendMoreThanStreamLimitRequestsConcurrently_LastWaits 1
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic ResponseCancellation_BothCancellationTokenAndDispose_Success 1

I can disable all if there's an easy way? Preview 7 is not going to build much longer though so it'd be your decision to make for main.

@karelz
Copy link
Member

karelz commented Jul 27, 2021

I would disable just the top hitters, incl. the 9-hits: #56194
In main, we are closely monitoring the results, disabling tests and needed. The general problem #55979 will have to be addressed soon ...

@stephentoub stephentoub merged commit d9c55e8 into dotnet:release/6.0-preview7 Jul 27, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants