Reconcile naming: RegexGeneratorAttribute to RegexAttribute

[am11]

Re: #62105 (comment).

In the upcoming .NET 7, we have [GeneratedDllImport] and [RegexGenerator] attributes to annotate partial methods for source generators.

It would be nice to match their names at this early stage, preferably by renaming [GeneratedDllImport] to [DllImportGenerator].

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[jkotas]

We also have prior art shipped in .NET 6:

• JsonSerializableAttribute
• LoggerMessageAttribute

I like that the .NET 6 names that they do include Generator or Generated at all. It makes them more succinct. Should we stick to this pattern for the new source generators as much as possible?

[jkotas]

For interop source generator, we can use this as an opportunity to switch to more platform neutral naming. Dll is Windows-specific. How about calling the attribute [LibraryImport]?

[ghost]

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Re: #62105 (comment).

In the upcoming .NET 7, we have [GeneratedDllImport] and [RegexGenerator] attributes to annotate partial methods for source generators.

It would be nice to match their names at this early stage, preferably by renaming [GeneratedDllImport] to [DllImportGenerator].

Author:	am11
Assignees:	-
Labels:	area-System.Text.RegularExpressions, untriaged
Milestone:	-

[jkotas]

Interop source generator API proposal is tracked by #46822 (it is not in public surface yet). This issue can be used to track what if anything we want to change for RegEx.

[RussKie]

How about calling the attribute [LibraryImport]?

More ideas: [Interop], [InteropImport], [PinvokeImport]

[MichalStrehovsky]

As Jan suggested, let's leave interop discussion in #46822. I moved the interop suggestions into that issue.

[joperezr]

Seems from the discussion that this is mainly to rename GeneratedDllImportAttribute right, and not so much for renaming RegexGeneratorAttribute?

[am11]

@joperezr, GeneratedDllImportAttribute was renamed to LibraryImportAttribute: #46822. This issue is tracking RegexGeneratorAttribute. Should we rename it to RegexAttribute?

RegexAttribute name is used in EntLib, but it is a rarely used library even with its NetCore port. If there is a chance of clash, it can be disambiguated using fully qualified names or with 'using' alias. It is the same situation as when System.Text.Rune was added, NStack.Core's System.Rune usages had to fully qualified the usages when upgrading projects to .NET 5 (one such project was gui.cs).

[joperezr]

@terrajobst @stephentoub @bartonjs thoughts on the above comment? If we want to change it, now is likely our last chance of doing so.

[stephentoub]

RegexGeneratorAttribute is unique amongst LibraryImportAttribute, JsonSerializableAttribute, and LoggingMessageAttribute including "generator" in the name. I'd be ok with RegexAttribute.

[terrajobst]

Video

• We'd prefer GeneratedRegexAttribute

 namespace System.Text.RegularExpressions;

 [AttributeUsage(AttributeTargets.Method, AllowMultiple = false, Inherited = false)]
-public partial class RegexGeneratorAttribute : Attribute
+public partial class GeneratedRegexAttribute : Attribute
 {
     // ....        
 }