Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider postponing reading and parsing of .deps.json in AssemblyDependencyResolver #89849

Open
vitek-karas opened this issue Aug 2, 2023 · 1 comment
Milestone

Comments

@vitek-karas
Copy link
Member

Currently AssemblyDependencyResolver does all the work in its constructor and caches the results for later use. Consider doing this lazily by storing the path to the assembly and only process its .deps.json when there's a first query on its contents.

To keep decent usability we should probably check the assembly path for existence in the .ctor and throw if it doesn't exist. But all the other failure modes would move from the constructor to the first usage.

@vitek-karas vitek-karas added this to the Future milestone Aug 2, 2023
@ghost
Copy link

ghost commented Aug 2, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently AssemblyDependencyResolver does all the work in its constructor and caches the results for later use. Consider doing this lazily by storing the path to the assembly and only process its .deps.json when there's a first query on its contents.

To keep decent usability we should probably check the assembly path for existence in the .ctor and throw if it doesn't exist. But all the other failure modes would move from the constructor to the first usage.

Author: vitek-karas
Assignees: -
Labels:

area-Host

Milestone: Future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant