.NET 8 RC1 can not compile with Windows app sdk and CsWinRT

[Gaoyifei1011]

Description

.NET 8 RC1 can not compile with Windows app sdk and CsWinRT

In.net8 RC1, the Marshal.QueryInterface() method is defined from
public static int QueryInterface (IntPtr pUnk, ref Guid iid, out IntPtr ppv);
Become a
public static int QueryInterface (IntPtr pUnk, in Guid iid, out IntPtr ppv);
Please update the content in WinRT.cs immediately, otherwise the application will not compile

Reproduction Steps

In describe bug

Expected behavior

In describe bug

Actual behavior

The Marshal.QueryInterface() method should be compatible with both ref and in arguments

Regression?

No response

Known Workarounds

No response

Configuration

.NET 8 RC1
Windows App SDK 1.4.0
CSWINRT 2.0.3

Other information

None

[ghost]

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

.NET 8 RC1 can not compile with Windows app sdk and CsWinRT

In.net8 RC1, the Marshal.QueryInterface() method is defined from
public static int QueryInterface (IntPtr pUnk, ref Guid iid, out IntPtr ppv);
Become a
public static int QueryInterface (IntPtr pUnk, in Guid iid, out IntPtr ppv);
Please update the content in WinRT.cs immediately, otherwise the application will not compile

Reproduction Steps

In describe bug

Expected behavior

In describe bug

Actual behavior

The Marshal.QueryInterface() method should be compatible with both ref and in arguments

Regression?

No response

Known Workarounds

No response

Configuration

.NET 8 RC1
Windows App SDK 1.4.0
CSWINRT 2.0.3

Other information

None

Author:	Gaoyifei1011
Assignees:	-
Labels:	area-System.Runtime.InteropServices
Milestone:	-

[AaronRobinsonMSFT]

This seems like a breaking change introduced in #89736.

@tannergooding I don't see any mitigations for the above change. There should have been a breaking change discussion, I wasn't involved so am unclear how to frame this to users.

[AaronRobinsonMSFT]

@Gaoyifei1011 The change to in here was a bit too aggressive. It should be either ref readonly or stay as ref. I will put up a PR shortly.

[Gaoyifei1011]

@Gaoyifei1011 The change to in here was a bit too aggressive. It should be either ref readonly or stay as ref. I will put up a PR shortly.

OK.Thanks for the quick fix

[hamarb123]

@Gaoyifei1011 could you please see #91983 (comment). Specifically, I'm interested if you have set warnings to errors, and if so you should be able to get VS to generate a #pragma warning disable for you to ignore the warning. Or are you using an outdated version of roslyn / VS preview, which may be causing it to show as an error?