You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While browsing some tests in the src/tests subtree, I found out some tests have their TestEntryPoint() method defined as void type. Consequently, the merged test's respective script will never know how the test truly went since it requires a return value.
For example, the way the script defines whether the test passed or not is with the following code:
{ ... }
export CLRTestExpectedExitCode=100
{ ... }
if [ $CLRTestExitCode-ne$CLRTestExpectedExitCode ]
thenecho END EXECUTION - FAILED
exit 1
elseecho END EXECUTION - PASSED
exit 0
fi
The script expects a 100 return code upon success, so the test would need to return an int type value.
The text was updated successfully, but these errors were encountered:
Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.
Issue Details
While browsing some tests in the src/tests subtree, I found out some tests have their TestEntryPoint() method defined as void type. Consequently, the merged test's respective script will never know how the test truly went since it requires a return value.
For example, the way the script defines whether the test passed or not is with the following code:
{ ... }
export CLRTestExpectedExitCode=100
{ ... }
if [ $CLRTestExitCode-ne$CLRTestExpectedExitCode ]
thenecho END EXECUTION - FAILED
exit 1
elseecho END EXECUTION - PASSED
exit 0
fi
The script expects a 100 return code upon success, so the test would need to return an int type value.
While browsing some tests in the
src/tests
subtree, I found out some tests have theirTestEntryPoint()
method defined asvoid
type. Consequently, the merged test's respective script will never know how the test truly went since it requires a return value.For example, the way the script defines whether the test passed or not is with the following code:
The script expects a 100 return code upon success, so the test would need to return an
int
type value.The text was updated successfully, but these errors were encountered: