Make sure separated_poh_p and use_large_pages_p works together #50665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 3 issues in the area:
If we decided to give some memory to POH even when it is set to 0, we should adjust the corresponding
heap_hard_limit
andheap_hard_limit_oh
to avoid failing thevirtual_commit
call. Thevirtual_commit
call consumes theheap_hard_limit
regardless of whether or not the memory is actually committed.In the large page case, if we decided to allocate the POH part of the memory using normal pages, then we need to commit them as well because the rest of the system assumes all the memory of large page cases is committed upfront.
virtual_free
could be called byreserve_initial_memory
if the memory operations fail, therefore it could be called in theheap_hard_limit
case as well, removing the erroneous assert in that case.