Large page testing #51255
Closed
Large page testing #51255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @hoyosjs Issue Details
|
2 tasks
cshung
force-pushed
the
private/andrewau/large-pages-testing
branch
2 times, most recently
from
3ce99b4
to
9ecc763
Compare
cshung
force-pushed
the
private/andrewau/large-pages-testing
branch
from
9ecc763
to
1a567c4
Compare
cshung
force-pushed
the
private/andrewau/large-pages-testing
branch
from
1a567c4
to
f1b1fd3
Compare
|
@cshung given that this PR is more than a year old can we close it and also delete the underlying branch? Currently the mapped branch is directly on dotnet/runtime and not on your fork. Thanks |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2019, we introduced the large page support in the GC. However, this feature is not regularly tested, and we found it broken (and fixed) once in a while due to careless changes.
It is time for us to introduce automated testing to avoid future regression.
Status: right now, we have the pipeline set up to build the product code, build the test code and run all the tests with the environment variables set. Unfortunately, there are some known failures, but those failures shouldn't block us from starting to test them regularly.
In order to avoid spinning cycles analyzing known failures, I turned the automatic scheduling off. The goal is to merge the change as is so that we can start to work to get the tests green. These tests will be run manually until we are done with fixing the tests (or excluding them due to compatibility reasons)