[mini] Dynamically allocate a buffer for large runtime invoke results #58215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: Issue DetailsIf the return type is a struct that's bigger than our buffer, malloc a Related to #58190
|
lambdageek
force-pushed
the
fix-gh-58190
branch
from
240fd42
to
40e0ca6
Compare
If the return type is a struct that's bigger than our buffer, malloc a buffer for it instead of using a fixed-size stack buffer
lambdageek
force-pushed
the
fix-gh-58190
branch
from
40e0ca6
to
ffa6cc9
Compare
Fixes various tests in InvokeRefReturnNetcoreTests
lambdageek
requested review from
imhameed,
SamMonoRT and
vargaz
as code owners
|
I think we want this for 6.0. |
imhameed
approved these changes
Aug 30, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1182670893 |
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Sep 11, 2021
Fixes dotnet#58957 Related to dotnet#58215 which was attempting to fix dotnet#58190
Anipik
pushed a commit
that referenced
this pull request
Sep 13, 2021
) * [mini] Use alloca for runtime_invoke retval buffer Fixes #58957 Related to #58215 which was attempting to fix #58190 * Set initial return buffer size to TARGET_SIZEOF_VOID_P In the common case we use the return buffer just to hold a pointer to the return value Co-authored-by: Aleksey Kliger <alklig@microsoft.com> Co-authored-by: Aleksey Kliger <aleksey@lambdageek.org>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the return type is a struct that's bigger than our buffer, malloc a buffer for it instead of using a fixed-size stack buffer.
Also take the ref-return logic from #52501 and add it to the non-LLVM runtime-invoke
This makes the
System.Runtimetestsuite (particularlyInvokeRefReturnNetcoreTests) pass on M1 MacCatalyst FullAOT.Related to #58190