[mini] Use alloca for runtime_invoke retval buffer #58978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#58957 Related to dotnet#58215 which was attempting to fix dotnet#58190
|
Tagging subscribers to this area: |
lambdageek
requested review from
imhameed,
SamMonoRT and
vargaz
as code owners
BrzVlad
reviewed
Sep 11, 2021
| gboolean retval_malloc = FALSE; | ||
| gpointer retval_ptr; | ||
| guint8 retval [MONO_SIZEOF_DYN_CALL_RET_BUF]; | ||
| int32_t retval_size = MONO_SIZEOF_DYN_CALL_RET_BUF; |
There was a problem hiding this comment.
Could the initial size be SIZEOF_VOID_P in order to avoid unnecessary stack allocation ?
In the common case we use the return buffer just to hold a pointer to the return value
BrzVlad
approved these changes
Sep 12, 2021
akoeplinger
approved these changes
Sep 12, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1227523946 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58957
Related to #58215 which was attempting to
fix #58190