Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code format #696

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Fix code format #696

merged 1 commit into from
Mar 7, 2019

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Mar 7, 2019

In corefx/coding-style.md at master · dotnet/corefx NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces (See issue 381 for examples). One exception is that a using statement is permitted to be nested within another using statement by starting on the following line at the same indentation level, even if the nested using contains a controlled block.

The document: https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/inheritance

In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces (See issue 381 for examples). One exception is that a using statement is permitted to be nested within another using statement by starting on the following line at the same indentation level, even if the nested using contains a controlled block.
@lindexi lindexi requested a review from BillWagner as a code owner March 7, 2019 06:02
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us to provide a more consistent view in our samples @lindexi
We appreciate your continued contributions.

I've reviewed this change, and I'll :shipit: now.

@BillWagner BillWagner merged commit 38b5f7e into dotnet:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants