Consider renaming build directory

[jaredpar]

This concerns primarily the directory sdk\src\Tasks\Microsoft.NET.Build.Tasks\build.

The Github searching / indexing logic will exclude directories with names "build", "log", "tmp" or "vendor". This exclusion is for all manner of searching including code content, file names, etc ...

This is unfortunately because a lot of the core logic for the SDK exists under this directory. I actually spent about 30+ minutes tracking down a bug because I couldn't locate Microsoft.NET.Sdk.CSharp.props. I was only able to find it when a search I did happened to include a clone of this repo.

I hate filing bugs like this because I don't think the github behavior is sensible here. But it is the behavior and it's severely reducing the usability of this repo via the web UI.

[NickCraver]

This explains several things I couldn't find as well. GitHub really shouldn't have this behavior at all - I've linked this to a few helpful folks there.

[davkean]

Ugh, this is unfortunate. Agree on the rename anyway - everytime I expect this to live under a "targets" directory.

[terrajobst]

Agree with @davkean. The silver lining is that the current name stinks anyways. I was trying this today as well and ended up cloning the repo and searching locally. Glad to hear it's not me being too stupid to use GitHub...

[eerhardt]

Just for some history/reasoning on why the folder was named that: this was originally a NuGet package that contained MSBuild logic. Inside your NuGet package, you put your MSBuild logic in a folder named "build" and then optionally a TFM sub-folder if your logic is TFM specific. Thus the file structure matched the NuGet structure.

This is no longer a NuGet package, so that reasoning no longer holds.

[eerhardt]

Trying this out, I'm a little confused.

https://github.com/search?l=&q=GenerateDepsFile+user%3Adotnet&ref=advsearch&type=Code&utf8=%E2%9C%93

That search does correctly find the 2 .targets files that call the GenerateDepsFile task, and they are both under the "build" directory.

Where can I find more information about

The Github searching / indexing logic will exclude directories with names "build", "log", "tmp" or "vendor".

[dasMulli]

At least the file search (t on code tab) doesn't work properly

[eerhardt]

Hmm, didn't know about that GH feature. 👍

[jaredpar]

@eerhardt

Where can I find more information about

The Github searching / indexing logic will exclude directories with names "build", "log", "tmp" or "vendor".

For this you'll need to contact Github. I only got this information from a support contact in response to my questions about why certain directories weren't being indexed.

[johnbeisner]

@jaredpar
Can you be more specific about what kind of search fails; I cannot reproduce your search failure.

I can indeed search file contents under "sdk\src\Tasks\Microsoft.NET.Build.Tasks\build" in github

[jaredpar]

@johnbeisner

Try searching for build.ps1. There is such a file under build\build.ps1 but it can't be found.

Honestly though, everyone has a build directory at this point. It's a really senseless limitation that GitHub has and we've all violated it at this point. I'd be fine with just closing this issue.