Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack should glob result of publish or not #1853

Closed
wli3 opened this issue Jan 12, 2018 · 2 comments
Closed

Pack should glob result of publish or not #1853

wli3 opened this issue Jan 12, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@wli3
Copy link

wli3 commented Jan 12, 2018

#1843 (comment)

Need further discussion

dasMulli
I think I suggested ResolvedFileToPublish previously but having doubts now. It could by PreserveNewest with some modification already done in the publish output or users could have targets with stuff in there. (or even post-built steps using xcopy execute).
The most "correct" but also slowest would be to do the same as the web sdk does for publishing - clean an intermediate directory and publish to it, then use a glob to harvest this clean publish. e.g. like #1846 (comment)

@wli3 wli3 self-assigned this Jan 12, 2018
@wli3 wli3 mentioned this issue Jan 12, 2018
@wli3 wli3 closed this as completed Jan 22, 2018
@wli3 wli3 reopened this Jan 22, 2018
@wli3 wli3 added the tool label Jan 25, 2018
@wli3 wli3 changed the title [tools] Pack should glob result of publish or not Pack should glob result of publish or not Jan 25, 2018
@livarcocc livarcocc added this to the Unknown milestone Feb 12, 2018
@wli3
Copy link
Author

wli3 commented Apr 18, 2018

ResolvedFileToPublish by the property name should be the right one to use. However in MSBuild the author can always override things. At the same time Publish folder could have similar issue when unexpected item being dropped to Publish folder. At lease we can avoid one globing, which is a big perf cost.

@wli3 wli3 closed this as completed Apr 18, 2018
@wli3
Copy link
Author

wli3 commented Apr 18, 2018

Close for now

JL03-Yue pushed a commit that referenced this issue Mar 19, 2024
Set minor version to help distinguish builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants