Properties and items aren't logged at evaluation for dotnet build

[KirillOsenkov]

Unlike MSBuild, when you run dotnet build, something is preventing the new behavior of logging properties and items after evaluation.

As a result we get legacy broken behavior where some properties and items are logged for some projects at ProjectStarted, but not others, and none at all are logged at evaluation.

This is very bad and we should fix this soon.

[KirillOsenkov]

dotnet msbuild doesn't work either.

[KirillOsenkov]

This needs to be opted into IEventSource4:

sdk/src/Cli/dotnet/commands/dotnet-msbuild/MSBuildForwardingLogger.cs

Line 21 in cf37f14

if (eventSource is IEventSource2 eventSource2)

[KirillOsenkov]

I saw six loggers under debugger, any idea if there are more?

[rainersigwald]

AFAIK this is the only default addition:

sdk/src/Cli/dotnet/commands/dotnet-msbuild/MSBuildForwardingApp.cs

Line 36 in cf37f14

$"-distributedlogger:{loggerType.FullName},{loggerType.GetTypeInfo().Assembly.Location}*{forwardingLoggerType.FullName},{forwardingLoggerType.GetTypeInfo().Assembly.Location}"

I also pointed you to the wrong implementation of the logger offline--we pass both the distributed and central logger, but it seems only the central logger needs to opt in for everything to work.

[KirillOsenkov]

Yes, seems reasonable: I saw 3 loggers on the build parameters, I'm guessing those are: Console, BinaryLogger and this logger. I saw 6 loggers on the LoggingService, and it means one central, one forwarding for each of those??

So it adds up. When we have a build of dotnet with this change, a simple way to test is just build any project with console and /bl and see if the evaluations have properties and items:

[rainersigwald]

Yup, that's what I see with my private build:

[KirillOsenkov]

Amazing!

I'm also thinking that currently if there are unenlightened loggers, there's no way to force the new behavior.

We should respect the environment variable if set, and force it to true regardless of which loggers. This would give us a way to turn it on via an environment variable as a workaround. Would have really saved my bacon right about now :)

[KirillOsenkov]

Something like this in the LoggingService.cs?

[KirillOsenkov]

I can PR this in a sec

[rainersigwald]

Yeah, I'd be on board for that.

[KirillOsenkov]

dotnet/msbuild#7217