Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove EnableWindowsTargeting #34495

Closed
anatawa12 opened this issue Aug 8, 2023 · 1 comment
Closed

remove EnableWindowsTargeting #34495

anatawa12 opened this issue Aug 8, 2023 · 1 comment
Labels
Area-NetSDK untriaged Request triage from a team member

Comments

@anatawa12
Copy link
Contributor

I think EnableWindowsTargeting guard for non-windows is a little annoying.

I don't know exactly why EnableWindowsTargeting property is exists, but I think one big reason is that apphost generation for windows GUI app requires windows.

In dotnet/runtime#89303, apphost generation for windows GUI app is now compatible with non-windows.
If there are no other reasons for EnableWindowsTargeting, I think it can be good to remove EnableWindowsTargeting guard for non-windows platform.

I'm sorry if there are some other reason why EnableWindowsTargeting is exists. However, I think it's better to have some documentation why EnableWindowsTargeting is exists.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Aug 8, 2023
@marcpopMSFT
Copy link
Member

There is more details on why this flag was added in this documentation. The flag is there for targeting pack downloads on non-windows platforms rather than related to the apphost.

@marcpopMSFT marcpopMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
rdeago added a commit to Tenacom/buildvana-builder that referenced this issue Apr 13, 2024
@rdeago
Set EnableWindowsTargeting to true in sample project.
3b1ca56 
https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1100
https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#enablewindowstargeting
dotnet/sdk#34495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcpopMSFT @anatawa12