-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target "BuiltProjectOutputGroup" does not exist when using <TargetFrameworks> #433
Comments
here's a workaround for anyone else in this situation: set <Private>False</Private> on the ProjectReference and then add it manually to VSIXSourceItem |
@gulbanana - can you link to an example of the workaround? I've been hit by this as well |
not open source, but here are the key changes:
|
After applying this workaround, I was still seeing the same error message. The issue was the lines like:
in the vsixmanifest. I changed these to include the outputs of the other projects as content, and then just referenced them as files in the vsixmanifest. |
The "right" fix here would be for the VSIX targets to respect the new metadata we define to specify what TargetFramework to build references for (dependent on the solution to dotnet/msbuild#1276). WorkaroundRight now you can manually specify that in a way that the VSIX collect-reference-outputs mechanism does respect, by specifying <ProjectReference Include="..\Other\Project.csproj">
<AdditionalProperties>TargetFramework=net452</AdditionalProperties>
</ProjectReference> If you want the outputs of multiple TFs, you must specify the ProjectReference multiple times with different metadata. |
* Makes WebCompiler compatible with .NET CLI version of MsBuild. * Updates the build configuration to not crash on missing nuspec. * Don't run "dotnet restore" on whole solution. * Makes "dotnet restore" run earlier. * Includes workaround for dotnet/sdk#433. * Fixes path to WebCompiler.pdb.
FWIW: In practice I found that @sharwell work around in #1580 is more correct here than @rainersigwald. The Reference often needs both the AdditionalProperties and Name elements in order to succeed. In some cases just AdditionalProperties is enough but have run into cases where both were indeed needed. |
When moving to the new SDK I initially disabled transitive project references because it was causing issues building our VSIX projects. Had some time this week to sit down and work through the problem which comes down to the VSIX indirectly referencing a multi-targetted project. This is a known bug in the SDK that can be worked around by doing the following: - Explicitly referencing the project - Using AdditionalProperties to specify the TF to use - Using Name to work around inability of VSSDK to infer Name The SDK bug is here. dotnet/sdk#433
Just wanted to chime in that this is still an issue today. |
This means that multi-targeting .net core projects cannot be referenced by VSIX projects, which invoke this target to discover what to include in the VSIX. All is well when using a single , but I cannot do that because of #266.
The text was updated successfully, but these errors were encountered: