Check dependencies in workload manifests #16746
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| [Fact] | ||
| public void ItChecksDependencies () | ||
| { | ||
| string MakeManifest(long version, params (string id, long version)[] dependsOn) |
There was a problem hiding this comment.
we want to use a string as the version right? Could make the change at the sametime? Looks like a big chunk of the code is to deal with the manifest version
|
looks good. Although tests are failing |
mhutch
force-pushed
the
workload-manifest-dependency-check
branch
from
c1b9d32
to
6f7ea15
Compare
|
Yes, should be good once CI checks complete. |
|
@mhutch I think there's a real test failure, it's failing consistently: https://dev.azure.com/dnceng/public/_build/results?buildId=1087788&view=ms.vss-test-web.build-test-results-tab&runId=33378866&resultId=100053&paneView=debug |
wli3
added
auto-merge
|
Hello @wli3! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
Check dependencies in workload manifests (dotnet#16746) * Implement workload manifest dependency validation * Test workload manifest dependency validation * Workload manifest version is now semver * Update projects that link/reference WorkloadManifestReader # Conflicts: # src/Tests/dotnet-workload-install.Tests/MockManifestProvider.cs
Check dependencies in workload manifests (dotnet#16746) * Implement workload manifest dependency validation * Test workload manifest dependency validation * Workload manifest version is now semver * Update projects that link/reference WorkloadManifestReader
Check dependencies in workload manifests (dotnet#16746) * Implement workload manifest dependency validation * Test workload manifest dependency validation * Workload manifest version is now semver * Update projects that link/reference WorkloadManifestReader
Check dependencies in workload manifests (dotnet#16746) * Implement workload manifest dependency validation * Test workload manifest dependency validation * Workload manifest version is now semver * Update projects that link/reference WorkloadManifestReader
Check dependencies in workload manifests (dotnet#16746) * Implement workload manifest dependency validation * Test workload manifest dependency validation * Workload manifest version is now semver * Update projects that link/reference WorkloadManifestReader
Check dependencies in workload manifests (dotnet#16746) * Implement workload manifest dependency validation * Test workload manifest dependency validation * Workload manifest version is now semver * Update projects that link/reference WorkloadManifestReader
No description provided.