Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing for arguments ending with dll/exe #28662

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

MarcoRossignoli
Copy link
Member

Fixes #28592

@MarcoRossignoli MarcoRossignoli requested a review from a team as a code owner October 19, 2022 14:39
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! A small question regarding one test.

@MarcoRossignoli MarcoRossignoli merged commit 2ab4f6b into dotnet:main Oct 19, 2022
@MarcoRossignoli MarcoRossignoli deleted the fixparse branch October 19, 2022 16:13
MarcoRossignoli added a commit to MarcoRossignoli/sdk that referenced this pull request Oct 25, 2022
Fix parsing for arguments ending with dll/exe
MarcoRossignoli added a commit that referenced this pull request Oct 25, 2022
Fix parsing for arguments ending with dll/exe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet test does not find any tests if environment variable is set that ends with dll
2 participants