Add a JsonSerializerIsReflectionEnabledByDefault property #31626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jkotas
reviewed
Apr 5, 2023
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Apr 6, 2023
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
…ext.Json one. Remove the defaulting of the System.Text.Json feature switch until a decision can be made when to turn it off by default.
|
I'm marking this PR as "ready for review". I've removed the defaulting of the feature switch until a decision can be made in dotnet/runtime#84378. I've removed the temporary ASP.NET JSON feature switch and am using the new one from System.Text.Json. This is needed to unblock ASP.NET work needed in preview4. So I want to get this merged without blocking on how to default the feature switch for all apps. |
eerhardt
approved these changes
Apr 13, 2023
jonathanpeppers
approved these changes
Apr 13, 2023
5 tasks
|
I'm going to merge this by EOD today to unblock ASP.NET. Please let me know if you have any feedback. |
vijayrkn
approved these changes
Apr 13, 2023
rolfbjarne
approved these changes
Apr 14, 2023
eiriktsarpalis
commented
Apr 14, 2023
…s move off of it.
|
I needed to add back the ASP.NET feature switch until we can move the ASP.NET libraries off of it. Need to do this in a staged manner so we don't regress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a msbuild property that ties to the feature switch implemented in dotnet/runtime#83844.
Also disables the property whenPublishAot=true.Remove ASP.NET's feature switch and use JsonSerializerIsReflectionEnabledByDefault instead.