Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable transitive pinning #34387

Merged
merged 9 commits into from
Aug 24, 2023
Merged

Conversation

marcpopMSFT
Copy link
Member

add a list of transitive packages used by msbuild, nuget, containers, and watch.

This won't fix external components like fsharp and watch.

Creating as a draft against my other branch so the diff can be viewed. This should retarget to main once #34344 goes in.

…by msbuild, nuget, containers, and watch.

This won't fix external components like fsharp and watch.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 2, 2023
eng/Versions.props Outdated Show resolved Hide resolved
Base automatically changed from marcpopMSFT-transitivepinning to main August 3, 2023 19:34
@marcpopMSFT marcpopMSFT marked this pull request as ready for review August 4, 2023 18:36
@marcpopMSFT
Copy link
Member Author

Adding @jaredpar as an expert on versioning. Seems like some sort of mismatch between multiple dependencies that shows up in the test run but not the build. Any ideas here on where to investigate next?

        C:\h\w\BE150A01\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(761,5): error MSB4018: The "GenerateClsidMap" task failed unexpectedly. [C:\h\w\BE150A01\t\dotnetSdkTests\ajqczyc0.vi5\It_fails_when---0653AA50\ComServerWithTypeLibs.csproj]
        C:\h\w\BE150A01\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(761,5): error MSB4018: System.MissingMethodException: Method not found: 'Void Microsoft.NET.HostModel.ComHost.ClsidMap.Create(System.Reflection.Metadata.MetadataReader, System.String)'. [C:\h\w\BE150A01\t\dotnetSdkTests\ajqczyc0.vi5\It_fails_when---0653AA50\ComServerWithTypeLibs.csproj]

@jaredpar
Copy link
Member

jaredpar commented Aug 7, 2023

Adding @jaredpar as an expert on versioning

Shots fired 😄

Seems like some sort of mismatch between multiple dependencies that shows up in the test run but not the build. Any ideas here on where to investigate next?

This line seems suspicious.

https://source.dot.net/#Microsoft.NET.Build.Tasks/TaskWithAssemblyResolveHooks.cs,30

Based on error it's seems very likely the problem is 8.0 version being loaded, task compiled against 7.0 and no binding redirects file being present. Do you have a fuslog?

@marcpopMSFT
Copy link
Member Author

Hmm, the code you linked is in a net472 block but I noticed that the tests in question only failed on the full msbuild leg (ie dotnet build worked just fine). I'll try to see if I can reproduce locally to gather more information.

@marcpopMSFT marcpopMSFT force-pushed the marcpopMSFT-transitivepinning-p2 branch from 6da2544 to d2e4ae6 Compare August 11, 2023 20:56
@marcpopMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT marcpopMSFT changed the base branch from main to release/8.0.1xx August 22, 2023 21:54
Directory.Packages.props Show resolved Hide resolved
@marcpopMSFT marcpopMSFT merged commit 587b4d9 into release/8.0.1xx Aug 24, 2023
16 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-transitivepinning-p2 branch August 24, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants